imalanik/BUTCube
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

COMM: Review - round 2

Browse Source
This commit is contained in:
Petr Malanik
2021-12-02 23:56:25 +01:00
parent 7f09b96f89
commit 232efab21b
6 changed files with 194 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

74
modules/Communication/OpenLST.kicad_sch
View File

@ -2018,21 +2018,31 @@
(junction (at 254 41.91) (diameter 1.016) (color 0 0 0 0))
(junction (at 254 49.53) (diameter 1.016) (color 0 0 0 0))
(no_connect (at 8.89 208.28) (uuid 604d9c7d-2d3c-4009-b9be-bfb7f1597047))
(no_connect (at 19.05 41.91) (uuid 4ae87010-1994-40c2-a0d9-176e9d8e05b5))
(no_connect (at 19.05 45.72) (uuid 748aade5-8eb2-470b-aa5f-86a59da28a23))
(no_connect (at 31.75 148.59) (uuid bd1c0dc9-9dab-4a8e-960f-1be5fb624ba2))
(no_connect (at 31.75 153.67) (uuid 2835a888-a3b6-4aa1-bcc0-c16b4cc0a324))
(no_connect (at 32.385 46.355) (uuid 4ae87010-1994-40c2-a0d9-176e9d8e05b5))
(no_connect (at 40.64 29.21) (uuid 1fe0feb1-2a3d-4d7d-ae9c-0e09d8d8aae5))
(no_connect (at 40.64 33.02) (uuid 431f45c9-33a6-4cd6-aa8e-0cfd43863de2))
(no_connect (at 40.64 34.29) (uuid 1fe0feb1-2a3d-4d7d-ae9c-0e09d8d8aae5))
(no_connect (at 40.64 36.83) (uuid dd9d7c69-42a8-4414-b13f-eb9c4e26c22d))
(no_connect (at 44.45 148.59) (uuid 1ed7ac17-6c61-4e9a-a0a5-ce3e8a7df851))
(no_connect (at 44.45 151.13) (uuid edbe6432-cdc2-4880-a5a5-187633fe248e))
(no_connect (at 44.45 153.67) (uuid ebb02fa3-ca97-44d1-9429-1497c5b0f1f5))
(no_connect (at 50.8 201.93) (uuid 0b2db45c-9a58-4126-9e75-37ad6d8e1f2a))
(no_connect (at 52.07 100.33) (uuid df72d2fc-ccdb-4b79-8a89-20cce0c913c5))
(no_connect (at 59.69 59.69) (uuid c58398fa-0f21-4bc7-a7af-cbf8538635e7))
(no_connect (at 88.9 173.99) (uuid d6349a9c-8ca8-4480-ac69-d2c5b1a905eb))
(no_connect (at 90.17 91.44) (uuid 07da0a64-f33b-469a-973d-c9b25dd8db9e))
(no_connect (at 90.17 102.87) (uuid 39387e56-b387-4959-94ce-73d8a78be2b3))
(no_connect (at 96.52 158.75) (uuid 0b2db45c-9a58-4126-9e75-37ad6d8e1f2a))
(no_connect (at 105.41 101.6) (uuid 0335c45a-d1d2-4eaa-befb-1a708a5c2108))
(no_connect (at 106.68 199.39) (uuid 73ccb9dc-21b7-42b4-bdcd-c48a0b5afbf7))
(no_connect (at 110.49 49.53) (uuid 2ad315fc-0257-4780-956b-a7c95388dacc))
(no_connect (at 251.46 97.79) (uuid f69c727c-cf15-44ef-bbb7-55c493ba44b2))
(no_connect (at 251.46 100.33) (uuid ee771831-bd6c-4140-95ae-f4245c540cb3))
(no_connect (at 251.46 102.87) (uuid db1a56a6-b7b9-4146-8cd1-d658900b5370))
(no_connect (at 254 30.48) (uuid 61ec4808-daaf-4059-ab83-795f9c8e5d19))
(no_connect (at 256.54 35.56) (uuid 2ae328a2-1f37-4790-9142-8cbce20a8a1f))
(wire (pts (xy 16.51 69.85) (xy 50.8 69.85))
(stroke (width 0) (type solid) (color 0 0 0 0))
@ -3219,27 +3229,64 @@
(uuid 2fed46af-ab5c-4f22-ad2e-9dac43568b3a)
)
(text "There probably should not be any\ncapacitors on USB data lines"
(at 10.16 212.09 0)
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid d14452e6-fb4a-4102-8854-a905489bcee0)
)
(text "USB Debug\n" (at 19.05 174.625 0)
(effects (font (size 2.5 2.5) (thickness 0.5) bold) (justify left bottom))
(uuid ffbd0ebf-b38b-4b5a-9945-43a384c02bd9)
)
(text "Missing power flag" (at 33.655 47.625 0)
(text "USB supplied source should not be\nconnected to EPS supplied source directly."
(at 20.32 48.26 0)
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid ef0c756b-7828-4e6e-9a29-0077e4c7d282)
)
(text "Missing power flag" (at 20.955 42.545 0)
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid ca09b965-e54f-4e78-9f0a-af753107e31d)
)
(text "All ICs are unavailable!" (at 41.91 30.48 0)
(text "All ICs are unavailable!" (at 41.91 35.56 0)
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid cfacdbd0-ac1c-4964-90ea-74f51fe0dcac)
)
(text "Many unconnected line near to labels" (at 41.91 34.29 0)
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid 0817da86-6f17-4efe-b768-1b1639a816f0)
)
(text "In case of implementation further review is required"
(at 41.91 38.1 0)
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid faf1fc97-886a-4a95-9565-cd58655df37e)
)
(text "Lines of crossing are too close\nLine is close to resistor\nBalue should not be inside resistor\nLines are not in grid\nLine impendace should be 22R"
(at 52.07 210.82 0)
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid 5b237358-a03e-4035-b05b-3c931d4f257f)
)
(text "This should be probably\nferrite bead not coil" (at 60.96 62.23 0)
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid 8cb925f4-eeaf-4d72-8e94-7781d5ad8af4)
)
(text "Power should be on pin 1 or 4\nnot in middle of connector"
(at 91.44 175.26 90)
(effects (font (size 1.27 1.27)) (justify right bottom))
(uuid c534ebfa-2422-41fc-b15d-813ce42f54b8)
)
(text "Unconnected wire" (at 97.79 160.02 0)
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid 79987fb5-d991-4429-adc2-99b55106061a)
)
(text "No jumper name" (at 106.68 102.87 0)
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid 4c1173e9-688c-4650-b40d-c2865c70a711)
)
(text "This should probably have X7R (or better) dielectric\nThis information should be in value or in note\n"
(at 107.95 203.2 0)
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid 098beb8b-0ffc-42fd-bbfe-9519e5929882)
)
(text "This should be probably\nferrite bead not coil" (at 111.76 52.07 0)
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid 1ffeb22f-00d1-432d-b425-e1d6b77a14dc)
)
(text "USB Power\n\n" (at 116.84 179.705 0)
(effects (font (size 2.5 2.5) (thickness 0.5) bold) (justify left bottom))
(uuid e8c843f8-b195-4ee0-a849-73779dcfba02)
@ -3281,6 +3328,15 @@
(effects (font (size 1.524 1.524)) (justify left bottom))
(uuid 5a8159b5-45a8-4d84-9662-cd724be18d8e)
)
(text "Local label, not working\nbetween hierarchical sheet"
(at 255.27 33.02 0)
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid e2a39ec0-b479-47f8-86e6-7e825d5861c3)
)
(text "Not connected to\nany power supply" (at 257.81 38.1 0)
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid 0525435c-3d26-4ce9-b0db-67f7e813691c)
)
(label "VDD_USB_LST" (at 17.145 54.61 0)
(effects (font (size 1.27 1.27)) (justify left bottom))