From 232efab21bb659ff6377893411e2447086041157 Mon Sep 17 00:00:00 2001 From: Petr Malanik Date: Thu, 2 Dec 2021 23:56:25 +0100 Subject: [PATCH] COMM: Review - round 2 --- modules/Communication/OpenLST.kicad_sch | 74 ++++++++++++++++--- modules/Communication/battSwitch.kicad_sch | 45 +++++++++++ modules/Communication/comm.kicad_sch | 46 +++++++++--- modules/Communication/gps_module.kicad_sch | 33 ++++++--- .../Communication/hf_transmitter.kicad_sch | 18 +---- modules/Communication/mcu_comm.kicad_sch | 30 ++++++-- 6 files changed, 193 insertions(+), 53 deletions(-) diff --git a/modules/Communication/OpenLST.kicad_sch b/modules/Communication/OpenLST.kicad_sch index b71ecdc..74aaf75 100644 --- a/modules/Communication/OpenLST.kicad_sch +++ b/modules/Communication/OpenLST.kicad_sch @@ -2018,21 +2018,31 @@ (junction (at 254 41.91) (diameter 1.016) (color 0 0 0 0)) (junction (at 254 49.53) (diameter 1.016) (color 0 0 0 0)) + (no_connect (at 8.89 208.28) (uuid 604d9c7d-2d3c-4009-b9be-bfb7f1597047)) + (no_connect (at 19.05 41.91) (uuid 4ae87010-1994-40c2-a0d9-176e9d8e05b5)) + (no_connect (at 19.05 45.72) (uuid 748aade5-8eb2-470b-aa5f-86a59da28a23)) (no_connect (at 31.75 148.59) (uuid bd1c0dc9-9dab-4a8e-960f-1be5fb624ba2)) (no_connect (at 31.75 153.67) (uuid 2835a888-a3b6-4aa1-bcc0-c16b4cc0a324)) - (no_connect (at 32.385 46.355) (uuid 4ae87010-1994-40c2-a0d9-176e9d8e05b5)) - (no_connect (at 40.64 29.21) (uuid 1fe0feb1-2a3d-4d7d-ae9c-0e09d8d8aae5)) - (no_connect (at 40.64 33.02) (uuid 431f45c9-33a6-4cd6-aa8e-0cfd43863de2)) + (no_connect (at 40.64 34.29) (uuid 1fe0feb1-2a3d-4d7d-ae9c-0e09d8d8aae5)) (no_connect (at 40.64 36.83) (uuid dd9d7c69-42a8-4414-b13f-eb9c4e26c22d)) (no_connect (at 44.45 148.59) (uuid 1ed7ac17-6c61-4e9a-a0a5-ce3e8a7df851)) (no_connect (at 44.45 151.13) (uuid edbe6432-cdc2-4880-a5a5-187633fe248e)) (no_connect (at 44.45 153.67) (uuid ebb02fa3-ca97-44d1-9429-1497c5b0f1f5)) + (no_connect (at 50.8 201.93) (uuid 0b2db45c-9a58-4126-9e75-37ad6d8e1f2a)) (no_connect (at 52.07 100.33) (uuid df72d2fc-ccdb-4b79-8a89-20cce0c913c5)) + (no_connect (at 59.69 59.69) (uuid c58398fa-0f21-4bc7-a7af-cbf8538635e7)) + (no_connect (at 88.9 173.99) (uuid d6349a9c-8ca8-4480-ac69-d2c5b1a905eb)) (no_connect (at 90.17 91.44) (uuid 07da0a64-f33b-469a-973d-c9b25dd8db9e)) (no_connect (at 90.17 102.87) (uuid 39387e56-b387-4959-94ce-73d8a78be2b3)) + (no_connect (at 96.52 158.75) (uuid 0b2db45c-9a58-4126-9e75-37ad6d8e1f2a)) + (no_connect (at 105.41 101.6) (uuid 0335c45a-d1d2-4eaa-befb-1a708a5c2108)) + (no_connect (at 106.68 199.39) (uuid 73ccb9dc-21b7-42b4-bdcd-c48a0b5afbf7)) + (no_connect (at 110.49 49.53) (uuid 2ad315fc-0257-4780-956b-a7c95388dacc)) (no_connect (at 251.46 97.79) (uuid f69c727c-cf15-44ef-bbb7-55c493ba44b2)) (no_connect (at 251.46 100.33) (uuid ee771831-bd6c-4140-95ae-f4245c540cb3)) (no_connect (at 251.46 102.87) (uuid db1a56a6-b7b9-4146-8cd1-d658900b5370)) + (no_connect (at 254 30.48) (uuid 61ec4808-daaf-4059-ab83-795f9c8e5d19)) + (no_connect (at 256.54 35.56) (uuid 2ae328a2-1f37-4790-9142-8cbce20a8a1f)) (wire (pts (xy 16.51 69.85) (xy 50.8 69.85)) (stroke (width 0) (type solid) (color 0 0 0 0)) @@ -3219,27 +3229,64 @@ (uuid 2fed46af-ab5c-4f22-ad2e-9dac43568b3a) ) + (text "There probably should not be any\ncapacitors on USB data lines" + (at 10.16 212.09 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid d14452e6-fb4a-4102-8854-a905489bcee0) + ) (text "USB Debug\n" (at 19.05 174.625 0) (effects (font (size 2.5 2.5) (thickness 0.5) bold) (justify left bottom)) (uuid ffbd0ebf-b38b-4b5a-9945-43a384c02bd9) ) - (text "Missing power flag" (at 33.655 47.625 0) + (text "USB supplied source should not be\nconnected to EPS supplied source directly." + (at 20.32 48.26 0) (effects (font (size 1.27 1.27)) (justify left bottom)) - (uuid ca09b965-e54f-4e78-9f0a-af753107e31d) + (uuid ef0c756b-7828-4e6e-9a29-0077e4c7d282) ) - (text "All ICs are unavailable!" (at 41.91 30.48 0) + (text "Missing power flag" (at 20.955 42.545 0) (effects (font (size 1.27 1.27)) (justify left bottom)) - (uuid cfacdbd0-ac1c-4964-90ea-74f51fe0dcac) + (uuid ca09b965-e54f-4e78-9f0a-af753107e31d) ) - (text "Many unconnected line near to labels" (at 41.91 34.29 0) + (text "All ICs are unavailable!" (at 41.91 35.56 0) (effects (font (size 1.27 1.27)) (justify left bottom)) - (uuid 0817da86-6f17-4efe-b768-1b1639a816f0) + (uuid cfacdbd0-ac1c-4964-90ea-74f51fe0dcac) ) (text "In case of implementation further review is required" (at 41.91 38.1 0) (effects (font (size 1.27 1.27)) (justify left bottom)) (uuid faf1fc97-886a-4a95-9565-cd58655df37e) ) + (text "Lines of crossing are too close\nLine is close to resistor\nBalue should not be inside resistor\nLines are not in grid\nLine impendace should be 22R" + (at 52.07 210.82 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 5b237358-a03e-4035-b05b-3c931d4f257f) + ) + (text "This should be probably\nferrite bead not coil" (at 60.96 62.23 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 8cb925f4-eeaf-4d72-8e94-7781d5ad8af4) + ) + (text "Power should be on pin 1 or 4\nnot in middle of connector" + (at 91.44 175.26 90) + (effects (font (size 1.27 1.27)) (justify right bottom)) + (uuid c534ebfa-2422-41fc-b15d-813ce42f54b8) + ) + (text "Unconnected wire" (at 97.79 160.02 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 79987fb5-d991-4429-adc2-99b55106061a) + ) + (text "No jumper name" (at 106.68 102.87 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 4c1173e9-688c-4650-b40d-c2865c70a711) + ) + (text "This should probably have X7R (or better) dielectric\nThis information should be in value or in note\n" + (at 107.95 203.2 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 098beb8b-0ffc-42fd-bbfe-9519e5929882) + ) + (text "This should be probably\nferrite bead not coil" (at 111.76 52.07 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 1ffeb22f-00d1-432d-b425-e1d6b77a14dc) + ) (text "USB Power\n\n" (at 116.84 179.705 0) (effects (font (size 2.5 2.5) (thickness 0.5) bold) (justify left bottom)) (uuid e8c843f8-b195-4ee0-a849-73779dcfba02) @@ -3281,6 +3328,15 @@ (effects (font (size 1.524 1.524)) (justify left bottom)) (uuid 5a8159b5-45a8-4d84-9662-cd724be18d8e) ) + (text "Local label, not working\nbetween hierarchical sheet" + (at 255.27 33.02 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid e2a39ec0-b479-47f8-86e6-7e825d5861c3) + ) + (text "Not connected to\nany power supply" (at 257.81 38.1 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 0525435c-3d26-4ce9-b0db-67f7e813691c) + ) (label "VDD_USB_LST" (at 17.145 54.61 0) (effects (font (size 1.27 1.27)) (justify left bottom)) diff --git a/modules/Communication/battSwitch.kicad_sch b/modules/Communication/battSwitch.kicad_sch index c794694..f4328b0 100644 --- a/modules/Communication/battSwitch.kicad_sch +++ b/modules/Communication/battSwitch.kicad_sch @@ -913,6 +913,15 @@ (junction (at 264.795 135.255) (diameter 1.016) (color 0 0 0 0)) (junction (at 273.05 135.255) (diameter 1.016) (color 0 0 0 0)) + (no_connect (at 20.32 143.51) (uuid 1bce82cd-a766-4698-a0b7-d8a07454721b)) + (no_connect (at 48.26 193.04) (uuid 959e33b0-09c6-4d53-bf63-e20a47487ac6)) + (no_connect (at 157.48 76.2) (uuid 978ff9a3-0790-4c33-b2e0-30f50ce1d80a)) + (no_connect (at 236.22 125.73) (uuid a41c5169-ec6e-4b89-a602-bed9b186e346)) + (no_connect (at 248.92 67.31) (uuid b82de8a7-3fa8-4357-9a00-ae5f27d25926)) + (no_connect (at 257.81 52.07) (uuid de16abed-cfd0-4e1f-8911-b8be414f2bfe)) + (no_connect (at 262.89 154.94) (uuid 0d04a5bd-25de-4014-ab6c-11bbb8e40c40)) + (no_connect (at 271.78 129.54) (uuid 0d04a5bd-25de-4014-ab6c-11bbb8e40c40)) + (wire (pts (xy 29.21 59.055) (xy 29.21 61.595)) (stroke (width 0) (type solid) (color 0 0 0 0)) (uuid 24a06fc1-5b8d-4dd2-9ab5-e4b388748d5f) @@ -1722,6 +1731,14 @@ (uuid 83e48cb2-889c-46fc-8a97-77b3f75c7b40) ) + (text "IC symbol is not\nup to standart" (at 21.59 146.05 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid cfcc7e69-97a8-4b02-b848-ca015eb493da) + ) + (text "Incorrect datasheet in\ncomponent desciption" (at 50.8 195.58 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid cf982ff2-7660-402f-8cb0-5a82cbc881cc) + ) (text "5V" (at 67.945 24.765 0) (effects (font (size 4 4) (thickness 0.8) bold) (justify left bottom)) (uuid 476a98ec-2d51-4d72-913d-5f98143e3d10) @@ -1730,6 +1747,11 @@ (effects (font (size 4 4) (thickness 0.8) bold) (justify left bottom)) (uuid c8157ed2-0168-4cc6-af08-2e2c0cd6b313) ) + (text "For sensing resistor also\npower rating or package\npackage should be in value\nor atleast in note close\nto sense resistor" + (at 156.21 87.63 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 7ae6b7c3-617b-4cf0-9771-925a58d52e81) + ) (text "VBAT TO 3V6" (at 209.55 111.125 0) (effects (font (size 4 4) (thickness 0.8) bold) (justify left bottom)) (uuid 33b0708c-a679-4760-a662-cee43804081f) @@ -1738,6 +1760,29 @@ (effects (font (size 4 4) (thickness 0.8) bold) (justify left bottom)) (uuid d58ad28b-0556-4cba-9923-8327a8a4272a) ) + (text "No IC descriptor, What is this chip?" (at 234.95 124.46 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid f7de867d-761c-4730-8db1-c30a79d9db33) + ) + (text "Inconsistent value format\ndescriptors, 100ns vs 0.1uF" + (at 248.92 72.39 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 3e2761c4-de26-41a1-9096-3d4c53fec71a) + ) + (text "Value of resistor is\nprobably to high for 3.3V" (at 259.08 54.61 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 63cc9379-b367-4ec0-9c75-9961ddaaa2e8) + ) + (text "Not adjustable output divider\n should contain potentiometer in series" + (at 264.16 157.48 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 0e613270-2d6f-44a2-875a-5f9d9278e914) + ) + (text "Local label, not working\nbetween hierarchical sheet" + (at 273.05 132.08 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 3403f4fc-6da2-4b5d-91fe-8ff43a8a6963) + ) (label "VBAT_OUT" (at 33.02 121.285 0) (effects (font (size 1.27 1.27)) (justify left bottom)) diff --git a/modules/Communication/comm.kicad_sch b/modules/Communication/comm.kicad_sch index 3a3e094..e65a298 100644 --- a/modules/Communication/comm.kicad_sch +++ b/modules/Communication/comm.kicad_sch @@ -17,7 +17,13 @@ + (no_connect (at 110.49 33.02) (uuid 3f44189a-ec4e-464c-b5b9-b7aec626e1b9)) + (no_connect (at 119.38 156.21) (uuid 3f44189a-ec4e-464c-b5b9-b7aec626e1b9)) (no_connect (at 127 140.97) (uuid 01191fff-702e-4722-88d7-a5a9a1781d7d)) + (no_connect (at 179.07 156.21) (uuid 3f44189a-ec4e-464c-b5b9-b7aec626e1b9)) + (no_connect (at 189.23 69.85) (uuid 8b7d91cd-d39f-4ac4-9299-5a5fc7fbf483)) + (no_connect (at 201.93 137.16) (uuid 5dfbfbde-d05d-4844-9ff6-e92647478341)) + (no_connect (at 210.82 34.29) (uuid 3f44189a-ec4e-464c-b5b9-b7aec626e1b9)) (wire (pts (xy 108.585 100.33) (xy 121.92 100.33)) (stroke (width 0) (type solid) (color 0 0 0 0)) @@ -416,19 +422,35 @@ (uuid 626db29b-b8f5-4340-8f5a-56eb4fa25e4b) ) + (text "!! No testpoints at all !!" (at 114.3 36.83 0) + (effects (font (size 5 5) (thickness 1) bold) (justify left bottom)) + (uuid d1aadd44-55ba-486f-8e7b-2db233cdb406) + ) + (text "!! RUN DRC !!" (at 123.19 160.02 0) + (effects (font (size 5 5) (thickness 1) bold) (justify left bottom)) + (uuid 1a3f1019-e614-4605-87d7-b29ca639d1b3) + ) (text "Inconsistent Interrupt naming" (at 128.27 142.24 0) (effects (font (size 1.27 1.27)) (justify left bottom)) (uuid c03bbd66-d85a-40f4-8caf-0dd4135e5d5d) ) + (text "Crossing like\nthis, what???" (at 190.5 72.39 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid ef86f237-7bfe-4542-a7e1-ef983ddc34b5) + ) + (text "No mounting holes" (at 203.2 138.43 0) + (effects (font (size 2 2)) (justify left bottom)) + (uuid 26bc5a60-11fb-43ec-94c8-e5565e4b48a3) + ) (sheet (at 152.4 46.99) (size 22.86 24.765) (fields_autoplaced) (stroke (width 0.1524) (type solid) (color 0 0 0 0)) (fill (color 0 0 0 0.0000)) (uuid 0335b19b-f69a-4698-b41d-d454ea335718) - (property "Název listu" "Battery load share" (id 0) (at 152.4 46.2784 0) + (property "Sheet name" "Battery load share" (id 0) (at 152.4 46.2784 0) (effects (font (size 1.27 1.27)) (justify left bottom)) ) - (property "Soubor listu" "battSwitch.kicad_sch" (id 1) (at 152.4 72.3396 0) + (property "Sheet file" "battSwitch.kicad_sch" (id 1) (at 152.4 72.3396 0) (effects (font (size 1.27 1.27)) (justify left top)) ) (pin "EPS#1_3V3" input (at 175.26 57.785 0) @@ -465,10 +487,10 @@ (stroke (width 0.1524) (type solid) (color 0 0 0 0)) (fill (color 0 0 0 0.0000)) (uuid 135894dc-6710-4561-8073-567533e9f424) - (property "Název listu" "GPS Module" (id 0) (at 83.82 95.1734 0) + (property "Sheet name" "GPS Module" (id 0) (at 83.82 95.1734 0) (effects (font (size 1.27 1.27)) (justify left bottom)) ) - (property "Soubor listu" "gps_module.kicad_sch" (id 1) (at 83.82 119.3296 0) + (property "Sheet file" "gps_module.kicad_sch" (id 1) (at 83.82 119.3296 0) (effects (font (size 1.27 1.27)) (justify left top)) ) (pin "INTERUPT" input (at 108.585 105.41 0) @@ -501,10 +523,10 @@ (stroke (width 0.1524) (type solid) (color 0 0 0 0)) (fill (color 0 0 0 0.0000)) (uuid 81a5172c-b171-400d-8856-41d6e486bdd1) - (property "Název listu" "MCU" (id 0) (at 136.525 88.8234 0) + (property "Sheet name" "MCU" (id 0) (at 136.525 88.8234 0) (effects (font (size 1.27 1.27)) (justify left bottom)) ) - (property "Soubor listu" "mcu_comm.kicad_sch" (id 1) (at 136.525 133.2996 0) + (property "Sheet file" "mcu_comm.kicad_sch" (id 1) (at 136.525 133.2996 0) (effects (font (size 1.27 1.27)) (justify left top)) ) (pin "RS_485_A" input (at 169.545 108.585 0) @@ -617,10 +639,10 @@ (stroke (width 0.1524) (type solid) (color 0 0 0 0)) (fill (color 0 0 0 0.0000)) (uuid 829b2795-9702-4633-a078-e2998d6d9402) - (property "Název listu" "OpenLST (Beacon)" (id 0) (at 81.915 54.5334 0) + (property "Sheet name" "OpenLST (Beacon)" (id 0) (at 81.915 54.5334 0) (effects (font (size 1.27 1.27)) (justify left bottom)) ) - (property "Soubor listu" "OpenLST.kicad_sch" (id 1) (at 81.915 79.3246 0) + (property "Sheet file" "OpenLST.kicad_sch" (id 1) (at 81.915 79.3246 0) (effects (font (size 1.27 1.27)) (justify left top)) ) (pin "UART0_CTS" input (at 109.855 74.93 0) @@ -649,10 +671,10 @@ (stroke (width 0.1524) (type solid) (color 0 0 0 0)) (fill (color 0 0 0 0.0000)) (uuid 3006f49f-d72b-4219-8dea-bda42cf88e84) - (property "Název listu" "Stack Connector" (id 0) (at 207.645 59.6134 0) + (property "Sheet name" "Stack Connector" (id 0) (at 207.645 59.6134 0) (effects (font (size 1.27 1.27)) (justify left bottom)) ) - (property "Soubor listu" "Stack_connector.kicad_sch" (id 1) (at 207.645 116.7896 0) + (property "Sheet file" "Stack_connector.kicad_sch" (id 1) (at 207.645 116.7896 0) (effects (font (size 1.27 1.27)) (justify left top)) ) (pin "CAN_H" input (at 207.645 88.265 180) @@ -725,10 +747,10 @@ (stroke (width 0.1524) (type solid) (color 0 0 0 0)) (fill (color 0 0 0 0.0000)) (uuid a345038c-0e2c-4410-9183-a80a047c8766) - (property "Název listu" "nRF Transceiver" (id 0) (at 84.455 130.7334 0) + (property "Sheet name" "nRF Transceiver" (id 0) (at 84.455 130.7334 0) (effects (font (size 1.27 1.27)) (justify left bottom)) ) - (property "Soubor listu" "hf_transmitter.kicad_sch" (id 1) (at 84.455 151.0796 0) + (property "Sheet file" "hf_transmitter.kicad_sch" (id 1) (at 84.455 151.0796 0) (effects (font (size 1.27 1.27)) (justify left top)) ) (pin "MOSI" input (at 106.68 137.16 0) diff --git a/modules/Communication/gps_module.kicad_sch b/modules/Communication/gps_module.kicad_sch index 59dda0f..516ef03 100644 --- a/modules/Communication/gps_module.kicad_sch +++ b/modules/Communication/gps_module.kicad_sch @@ -509,14 +509,16 @@ (junction (at 155.575 85.725) (diameter 1.016) (color 0 0 0 0)) (junction (at 164.465 83.185) (diameter 1.016) (color 0 0 0 0)) + (no_connect (at 45.72 118.11) (uuid fa4b8c7e-d4ed-40db-8f48-c10fb74088cf)) (no_connect (at 58.42 71.12) (uuid 85201180-d2ed-4b0d-81b0-9e79da370ca6)) (no_connect (at 58.42 73.66) (uuid 85201180-d2ed-4b0d-81b0-9e79da370ca6)) (no_connect (at 58.42 99.06) (uuid 4009b76d-4e12-41c2-8abc-3c909f129ef1)) - (no_connect (at 86.36 50.165) (uuid 9b815f68-a45a-4127-9423-cdd83a06ce58)) - (no_connect (at 86.36 56.515) (uuid a9289e3e-6f9e-45ad-b6b7-28ae328600f3)) + (no_connect (at 80.01 41.91) (uuid 9b815f68-a45a-4127-9423-cdd83a06ce58)) + (no_connect (at 80.01 48.26) (uuid a2dc883e-8be8-4b4b-99f0-879d05dff671)) (no_connect (at 93.98 93.98) (uuid 640c81af-5b52-4930-825d-dea52c971932)) - (no_connect (at 140.335 55.245) (uuid 4ff146fd-0bfd-4102-8960-a7fdb5091651)) - (no_connect (at 140.335 60.325) (uuid 98eb6060-9d50-40a5-94eb-83c0e8b85566)) + (no_connect (at 104.14 74.93) (uuid 200be9b2-43a8-498b-a2f1-217b5feaed58)) + (no_connect (at 133.35 68.58) (uuid 5336eac4-105f-430d-89b3-93768eacb78d)) + (no_connect (at 133.35 72.39) (uuid 16a2b90c-bf42-469d-9225-99717144eb37)) (wire (pts (xy 48.895 86.36) (xy 58.42 86.36)) (stroke (width 0) (type solid) (color 0 0 0 0)) @@ -703,13 +705,21 @@ (effects (font (size 1.27 1.27)) (justify left bottom)) (uuid cdf36631-0b51-4d27-94ca-d6a112c60208) ) - (text "Missing Capacitor on Power supply\n(low ESR)" (at 87.63 53.975 0) + (text "Power flag should\nnot be facing down" (at 46.99 120.65 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 395fc99b-797b-4962-8870-000b27f2b5c4) + ) + (text "Missing Capacitor on Power supply\n(low ESR)" (at 81.28 45.72 0) (effects (font (size 1.27 1.27)) (justify left bottom)) (uuid 998aa15a-aab2-47f8-95be-c3a0a284deb3) ) - (text "No bypass capacitors" (at 87.63 57.785 0) + (text "+3V3 label probably already contains power flag" (at 81.28 49.53 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 76fef2e2-188b-498a-b1a8-c51d72e93f4d) + ) + (text "Rotated\nvalues" (at 105.41 77.47 0) (effects (font (size 1.27 1.27)) (justify left bottom)) - (uuid 0b42d314-3a79-448a-ae45-66bbce0c5e0c) + (uuid 0547aed6-d049-4283-b302-d86b2716024e) ) (text "Output pin to I-PEX connector, for connect external antena\nActive antenna - min gain 15dB (compensate singal lost on RF cable)\n - max 30dB\n -- max noise figure 1,5dB\n\nPossible antena: GPS-ANT044 SR PASSIVES\n" (at 110.49 115.57 0) @@ -720,14 +730,13 @@ (effects (font (size 1.27 1.27)) (justify left bottom)) (uuid a085bfcb-e4e0-4cb6-9424-1b40a095a96a) ) - (text "No antenna specification (only patch is not sufficient)\nExternal LNA or active antena should be used" - (at 141.605 57.785 0) + (text "No background\ninside symbol?" (at 134.62 69.85 0) (effects (font (size 1.27 1.27)) (justify left bottom)) - (uuid 912f6073-bfe7-4b15-b52d-9d1b9b3cb0c0) + (uuid 6675339d-b136-4387-8643-2131d9cac758) ) - (text "Missing information about antenna routing" (at 141.605 60.96 0) + (text "GND upwards? NO" (at 134.62 73.66 0) (effects (font (size 1.27 1.27)) (justify left bottom)) - (uuid 191e82d5-e216-4e16-9901-6cf435ad0fb5) + (uuid fc5796b4-a681-4456-bfd8-f8c508747119) ) (text "https://www.guerrilla-rf.com/products/CustomTunes?sku=2133&file_name=GRF2133%201200-1600MHz.pdf" (at 141.605 117.475 0) diff --git a/modules/Communication/hf_transmitter.kicad_sch b/modules/Communication/hf_transmitter.kicad_sch index 7b07808..cb601d0 100644 --- a/modules/Communication/hf_transmitter.kicad_sch +++ b/modules/Communication/hf_transmitter.kicad_sch @@ -503,9 +503,7 @@ (junction (at 160.655 91.44) (diameter 1.016) (color 0 0 0 0)) (no_connect (at 50.8 48.895) (uuid b27c77d1-8477-4e54-9a4b-5f0cda8ef123)) - (no_connect (at 117.475 51.435) (uuid 17581ce2-2586-4cff-8d36-414362c0c2f6)) - (no_connect (at 117.475 55.245) (uuid 5828b0e2-83e3-44fc-b317-a9acb25f2a7f)) - (no_connect (at 154.94 72.39) (uuid dab6cce1-28a1-41cd-8447-2072483b5f1c)) + (no_connect (at 182.88 104.14) (uuid 5828b0e2-83e3-44fc-b317-a9acb25f2a7f)) (wire (pts (xy 41.91 57.785) (xy 55.245 57.785)) (stroke (width 0) (type solid) (color 0 0 0 0)) @@ -757,22 +755,14 @@ (effects (font (size 1.27 1.27)) (justify left bottom)) (uuid 2dba63b1-340e-4a54-a67f-2df370b81af2) ) - (text "Ground upwards? c'mon" (at 118.745 52.705 0) + (text "50 Ohm\nImpedance" (at 166.37 89.535 0) (effects (font (size 1.27 1.27)) (justify left bottom)) - (uuid 957f290b-a858-46f3-9890-fcd9ed8a12a7) + (uuid 768ba762-c02d-4aec-8ffa-3709cdf09721) ) - (text "Some GND have labels some not?" (at 118.745 56.515 0) + (text "Some GND have labels some not?" (at 184.15 105.41 0) (effects (font (size 1.27 1.27)) (justify left bottom)) (uuid a62ae571-4c40-4ca6-9d7a-351af43cf371) ) - (text "Missing information about antena routing" (at 156.21 73.66 0) - (effects (font (size 1.27 1.27)) (justify left bottom)) - (uuid 6baa2896-4452-4d58-96cb-d5373ccbb357) - ) - (text "50 Ohm\nImpedance" (at 166.37 89.535 0) - (effects (font (size 1.27 1.27)) (justify left bottom)) - (uuid 768ba762-c02d-4aec-8ffa-3709cdf09721) - ) (text "I-PEX connector\n" (at 196.215 85.09 180) (effects (font (size 1.27 1.27)) (justify right bottom)) (uuid bc4972f2-e9bb-454a-b83f-ddb8e4ed6f37) diff --git a/modules/Communication/mcu_comm.kicad_sch b/modules/Communication/mcu_comm.kicad_sch index 2f5d709..4d3b28f 100644 --- a/modules/Communication/mcu_comm.kicad_sch +++ b/modules/Communication/mcu_comm.kicad_sch @@ -1825,7 +1825,10 @@ (junction (at 260.35 150.495) (diameter 0.9144) (color 0 0 0 0)) (junction (at 260.35 160.655) (diameter 0.9144) (color 0 0 0 0)) + (no_connect (at 15.24 184.15) (uuid 6cfe5ab9-2e1d-4eff-a4e7-10b69327c163)) (no_connect (at 33.655 44.45) (uuid c20b32bc-16b5-4a14-abcf-ed25ee2b1b4a)) + (no_connect (at 43.18 139.7) (uuid 5522011f-5171-487b-b668-87d932989e66)) + (no_connect (at 67.31 151.13) (uuid d4e44e4f-9ffb-44ad-8264-36db91914386)) (no_connect (at 95.885 43.815) (uuid 58aa9bf0-2b8d-4f09-9852-144033041c8b)) (no_connect (at 113.665 90.805) (uuid f8dfa690-166a-483b-b0e7-099c24dfd9cc)) (no_connect (at 113.665 93.345) (uuid f8dfa690-166a-483b-b0e7-099c24dfd9cc)) @@ -1833,7 +1836,7 @@ (no_connect (at 123.825 78.105) (uuid f8dfa690-166a-483b-b0e7-099c24dfd9cc)) (no_connect (at 146.685 32.385) (uuid 8740f14b-f9b3-44fc-bc70-0ab09c84cf20)) (no_connect (at 160.02 137.16) (uuid 61e217e3-f875-4369-b3db-768ec349b53a)) - (no_connect (at 226.06 39.37) (uuid 290eeba7-3b69-4d3e-831b-508c61b337ce)) + (no_connect (at 250.19 40.64) (uuid 2aee8c6d-b65e-4901-9fb5-c09a3aba8e97)) (wire (pts (xy 13.335 162.56) (xy 37.465 162.56)) (stroke (width 0) (type solid) (color 0 0 0 0)) @@ -2705,6 +2708,11 @@ (effects (font (size 1.27 1.27)) (justify left bottom)) (uuid 00a52d88-8800-45e5-a63c-b26231316755) ) + (text "There probably should not be any\ncapacitors on USB data lines" + (at 16.51 187.96 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 2ebba203-12a8-42e2-b947-e5053bbc91e2) + ) (text "Reset button is separated from Watchdog, to enable\nreset by button when watchdog is disconnected" (at 17.145 76.2 0) (effects (font (size 1.27 1.27)) (justify left bottom)) @@ -2714,6 +2722,11 @@ (effects (font (size 2 2) (thickness 0.4) bold) (justify left bottom)) (uuid a8c311b3-ed81-4119-b589-93a5c63e6751) ) + (text "Value of solder jumper\nshould be his purpose\nEx: USB_SEL" + (at 44.45 144.78 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid f3390598-4ea5-455e-801e-25ef06ec087f) + ) (text "Reset" (at 45.085 71.12 0) (effects (font (size 2 2) (thickness 0.4) bold) (justify left bottom)) (uuid 480c3375-4523-48e7-98c1-d9b31b518a4c) @@ -2726,6 +2739,10 @@ (effects (font (size 1.27 1.27)) (justify left bottom)) (uuid f5dcdd11-ce97-4b1f-ba59-c27cf847f283) ) + (text "USB wires order" (at 68.58 152.4 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid b1b5ee04-8811-4c7e-ab51-d396d53c9eee) + ) (text "High-Speed oscillator" (at 85.725 171.45 0) (effects (font (size 2 2) (thickness 0.4) bold) (justify left bottom)) (uuid 7cd06a7f-06fa-4cd5-a879-1226b343440f) @@ -2746,7 +2763,8 @@ (effects (font (size 1.27 1.27)) (justify left bottom)) (uuid f7d9b2ec-c0df-4662-90c8-9909c84b451c) ) - (text "USB should be\ndifferential" (at 161.29 139.7 0) + (text "USB should be differential, adjust wire naming to that\nNew version probably have support for P/N -> Check that!!\n" + (at 172.72 151.13 90) (effects (font (size 1.27 1.27)) (justify left bottom)) (uuid 46e5f71d-34ce-43f8-ba05-1401f11d9e0d) ) @@ -2768,10 +2786,6 @@ (effects (font (size 1.27 1.27)) (justify left bottom)) (uuid b241b1f5-8a83-4767-948f-d4633a553b85) ) - (text "Insufficient decoupling capacitors" (at 227.33 40.64 0) - (effects (font (size 1.27 1.27)) (justify left bottom)) - (uuid 30ca5fa1-f582-4220-bbd1-2b26bb54cee9) - ) (text "Decoupled MCU capacitors" (at 228.6 24.13 0) (effects (font (size 1.5 1.5)) (justify left bottom)) (uuid 7b7658d3-0141-4ca6-bd5f-273daa58cfc3) @@ -2788,6 +2802,10 @@ (effects (font (size 1.27 1.27)) (justify left bottom)) (uuid f89a1843-75f1-472c-91bd-d4717783d54d) ) + (text "Why VSS label on GND,\nconfusing as hell" (at 251.46 44.45 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 20126183-2495-408b-8fc0-0e9e229de270) + ) (label "USB_DBG_DP" (at 13.335 162.56 0) (effects (font (size 1.27 1.27)) (justify left bottom))