COMM: Review - round 4

CommModule
Petr Malanik 3 years ago committed by Štěpán Rydlo
parent a88c93c9df
commit 07f234b367

File diff suppressed because it is too large Load Diff

@ -729,7 +729,13 @@
(uuid ee58b9e2-2293-4041-98ac-b810e072ff5d)
)
(no_connect (at 201.93 111.76) (uuid 13f97320-83d6-4461-b67a-c35bdaa69c24))
(no_connect (at 170.18 50.8) (uuid 82e5ea2d-acde-40d4-b80d-7e85e848f6e3))
(no_connect (at 234.95 101.6) (uuid 88da4feb-5ac5-4c93-8129-1e77912cab38))
(no_connect (at 246.38 69.85) (uuid b12f7ca8-1afd-4997-9e4a-6ebc88b8e32c))
(no_connect (at 257.81 90.17) (uuid da154739-7b92-49a1-aa24-f125851e8a7c))
(no_connect (at 7.62 86.36) (uuid e3e8f4d4-32e0-4246-91d3-179118387393))
(no_connect (at 76.2 102.87) (uuid f3d1583c-719f-4908-9caf-0d3090268652))
(wire (pts (xy 196.215 102.87) (xy 198.12 102.87))
(stroke (width 0) (type solid) (color 0 0 0 0))
@ -739,6 +745,11 @@
(stroke (width 0) (type solid) (color 0 0 0 0))
(uuid 0cceca1d-8f92-4069-96bd-f4c6a84bcb3f)
)
(bus (pts (xy 246.38 71.12) (xy 247.65 80.01))
(stroke (width 0) (type dot) (color 0 0 0 0))
(uuid 120e0585-9799-43d9-90fa-83e722fa8c33)
)
(wire (pts (xy 227.33 96.52) (xy 227.33 97.79))
(stroke (width 0) (type solid) (color 0 0 0 0))
(uuid 17506401-c505-4b8a-8c02-9c0a9283390f)
@ -755,6 +766,11 @@
(stroke (width 0) (type solid) (color 0 0 0 0))
(uuid 1f07c9e6-a716-4ecb-9330-f0a8ddd49180)
)
(bus (pts (xy 58.42 88.9) (xy 74.93 102.87))
(stroke (width 0) (type dot) (color 0 0 0 0))
(uuid 25d0b121-6b40-48f6-a45b-eda610bd7ba4)
)
(wire (pts (xy 161.29 80.645) (xy 166.37 80.645))
(stroke (width 0) (type solid) (color 0 0 0 0))
(uuid 261ceb10-a1c0-41ec-8894-558a20ffb8c1)
@ -791,6 +807,15 @@
(stroke (width 0) (type solid) (color 0 0 0 0))
(uuid 5462e273-4610-4de9-bc3b-fa2760ac4fe7)
)
(bus (pts (xy 224.79 105.41) (xy 224.79 81.28))
(stroke (width 0) (type dot) (color 0 0 0 0))
(uuid 554b12f8-26e8-4f25-90de-cda584823f93)
)
(bus (pts (xy 224.79 105.41) (xy 233.68 105.41))
(stroke (width 0) (type dot) (color 0 0 0 0))
(uuid 5beff8a3-8630-4bb0-bd39-70da8abbf114)
)
(wire (pts (xy 203.2 74.295) (xy 205.74 74.295))
(stroke (width 0) (type solid) (color 0 0 0 0))
(uuid 6082495c-64e5-4c52-ba04-b3834667a4e9)
@ -831,6 +856,11 @@
(stroke (width 0) (type solid) (color 0 0 0 0))
(uuid 725bac89-d139-4a83-8c1a-9af707195196)
)
(bus (pts (xy 233.68 81.28) (xy 233.68 105.41))
(stroke (width 0) (type dot) (color 0 0 0 0))
(uuid 7dcc0bfe-b767-4758-a88d-2865170050e6)
)
(wire (pts (xy 182.245 93.98) (xy 182.245 92.075))
(stroke (width 0) (type solid) (color 0 0 0 0))
(uuid 7f50fdac-0d80-4715-8667-dc57a0ec19d4)
@ -839,6 +869,11 @@
(stroke (width 0) (type solid) (color 0 0 0 0))
(uuid 81831b8a-5454-47d8-a047-e60a79872195)
)
(bus (pts (xy 224.79 81.28) (xy 233.68 81.28))
(stroke (width 0) (type dot) (color 0 0 0 0))
(uuid 893533a1-9350-4134-840e-44f9ab66d505)
)
(wire (pts (xy 227.33 80.645) (xy 227.33 81.28))
(stroke (width 0) (type solid) (color 0 0 0 0))
(uuid 8c60b43a-9084-41a3-8680-dc43d33c20b4)
@ -887,6 +922,11 @@
(stroke (width 0) (type solid) (color 0 0 0 0))
(uuid b2742f2a-3867-4be4-a359-fdc03dada4ae)
)
(bus (pts (xy 229.87 90.17) (xy 256.54 90.17))
(stroke (width 0) (type dot) (color 0 0 0 0))
(uuid b2d21548-a3ac-4a22-9152-92c62926a9fa)
)
(wire (pts (xy 69.85 84.455) (xy 83.185 84.455))
(stroke (width 0) (type solid) (color 0 0 0 0))
(uuid b6a3e3d7-bc8f-488e-8493-f1a588592b83)
@ -927,6 +967,11 @@
(stroke (width 0) (type solid) (color 0 0 0 0))
(uuid c7625d30-f230-426f-93bf-81ce31181ec4)
)
(bus (pts (xy 26.67 91.44) (xy 49.53 92.71))
(stroke (width 0) (type dot) (color 0 0 0 0))
(uuid c7a81980-bb6d-46b4-a8bd-da07bb3c1015)
)
(wire (pts (xy 83.185 84.455) (xy 95.25 84.455))
(stroke (width 0) (type solid) (color 0 0 0 0))
(uuid c9f2d6de-b63c-40ac-8f21-2db700cb8ad6)
@ -943,6 +988,11 @@
(stroke (width 0) (type solid) (color 0 0 0 0))
(uuid d912ce47-8d07-4b9f-8ac9-355eb78207fb)
)
(bus (pts (xy 203.2 110.49) (xy 209.55 95.25))
(stroke (width 0) (type dot) (color 0 0 0 0))
(uuid d99a137c-4e94-4bb3-af5b-1cd631ee4038)
)
(wire (pts (xy 222.25 96.52) (xy 222.25 99.06))
(stroke (width 0) (type solid) (color 0 0 0 0))
(uuid de6087b2-e236-4764-bbd3-27ef6c3e7ed9)
@ -989,6 +1039,36 @@
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid 1ab99666-2754-4e03-a7fb-1d935cf15685)
)
(text "Some source for this value?\nNot sure about frequency error amplification\n with this value of filter."
(at 204.47 119.38 0)
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid 30b9fc25-70d0-4f49-87e8-b2653e234c64)
)
(text "Total resistance is too low\nShould be in range 500 - 1000 kR\nAssume low power operation"
(at 236.22 106.68 0)
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid 4cc0770f-f194-41f8-b176-22eddefde581)
)
(text "Most of thetrimrs in Kicad\nhas different pinout numbering.\n\nThis numbering is common for potentiometer."
(at 259.08 93.98 0)
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid 51aff4cc-24e2-460b-b9c5-5911d79b1ffc)
)
(text "If logic is inverted this should \n be reflected in label by ~{EN}\nLogic is probably inverted !!!"
(at 10.16 88.9 0)
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid 5e513b3c-fd2e-40c3-b053-43313a9ab6f9)
)
(text "As was said at last round of review\nGate threshold voltage is not enought to close this mosfet.\nWhen MOSFET should be disabled voltage V_{GS} is -1.4V\n But MOSFET Threshold voltage is -1 to 2.5V\nWith low current flow this mosfet will be open even when it should be disabled."
(at 77.47 109.22 0)
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid 96eb817a-341f-49a7-912e-92df87d08c00)
)
(text "Incorrect capacitor selection\nfor pulse load of RF system.\nDatasheet page 13."
(at 248.92 73.66 0)
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid 9c339621-8fb3-41c6-870e-7a83e5295657)
)
(text "low ESR as close as\npossible to VIN\n" (at 172.72 97.79 180)
(effects (font (size 1.27 1.27)) (justify right bottom))
(uuid e85887f4-0ced-4173-9c97-81e8392e3ff9)

File diff suppressed because it is too large Load Diff

@ -2114,22 +2114,22 @@
(path "/829b2795-9702-4633-a078-e2998d6d9402/2dfbd262-160c-46e9-98d6-15ca69286968"
(reference "TP?") (unit 1) (value "~") (footprint "")
)
(path "/a161eaab-f432-4250-8567-12738a9776f7/304f25fe-e38d-4377-b8f1-26289354f05c"
(path "/5d794243-d9db-4c8e-aa14-90dff0141470/304f25fe-e38d-4377-b8f1-26289354f05c"
(reference "TP?") (unit 1) (value "OUT2") (footprint "")
)
(path "/5d794243-d9db-4c8e-aa14-90dff0141470/304f25fe-e38d-4377-b8f1-26289354f05c"
(path "/a161eaab-f432-4250-8567-12738a9776f7/304f25fe-e38d-4377-b8f1-26289354f05c"
(reference "TP?") (unit 1) (value "OUT2") (footprint "")
)
(path "/d3a682e4-d5b0-4377-8f5c-e0ae4cebf08d/267a91a1-f60f-4e4e-a455-eed28f022043/304f25fe-e38d-4377-b8f1-26289354f05c"
(reference "TP?") (unit 1) (value "OUT2") (footprint "")
)
(path "/d3a682e4-d5b0-4377-8f5c-e0ae4cebf08d/267a91a1-f60f-4e4e-a455-eed28f022043/4be1be59-191f-4e68-88ec-9dc9ef6dd51c"
(path "/a161eaab-f432-4250-8567-12738a9776f7/4be1be59-191f-4e68-88ec-9dc9ef6dd51c"
(reference "TP?") (unit 1) (value "OUT1") (footprint "")
)
(path "/5d794243-d9db-4c8e-aa14-90dff0141470/4be1be59-191f-4e68-88ec-9dc9ef6dd51c"
(path "/d3a682e4-d5b0-4377-8f5c-e0ae4cebf08d/267a91a1-f60f-4e4e-a455-eed28f022043/4be1be59-191f-4e68-88ec-9dc9ef6dd51c"
(reference "TP?") (unit 1) (value "OUT1") (footprint "")
)
(path "/a161eaab-f432-4250-8567-12738a9776f7/4be1be59-191f-4e68-88ec-9dc9ef6dd51c"
(path "/5d794243-d9db-4c8e-aa14-90dff0141470/4be1be59-191f-4e68-88ec-9dc9ef6dd51c"
(reference "TP?") (unit 1) (value "OUT1") (footprint "")
)
(path "/d3a682e4-d5b0-4377-8f5c-e0ae4cebf08d/4db093e3-b194-40a9-987a-1e48c698f5f0"
@ -2168,10 +2168,10 @@
(path "/a161eaab-f432-4250-8567-12738a9776f7/cac0bb29-d39d-4fdc-b6eb-30f19a995d23"
(reference "TP?") (unit 1) (value "VIN1") (footprint "")
)
(path "/d3a682e4-d5b0-4377-8f5c-e0ae4cebf08d/267a91a1-f60f-4e4e-a455-eed28f022043/d8d04eb0-7ed8-4205-bb00-15d7a4a02a43"
(path "/5d794243-d9db-4c8e-aa14-90dff0141470/d8d04eb0-7ed8-4205-bb00-15d7a4a02a43"
(reference "TP?") (unit 1) (value "VIN2") (footprint "")
)
(path "/5d794243-d9db-4c8e-aa14-90dff0141470/d8d04eb0-7ed8-4205-bb00-15d7a4a02a43"
(path "/d3a682e4-d5b0-4377-8f5c-e0ae4cebf08d/267a91a1-f60f-4e4e-a455-eed28f022043/d8d04eb0-7ed8-4205-bb00-15d7a4a02a43"
(reference "TP?") (unit 1) (value "VIN2") (footprint "")
)
(path "/a161eaab-f432-4250-8567-12738a9776f7/d8d04eb0-7ed8-4205-bb00-15d7a4a02a43"

File diff suppressed because it is too large Load Diff

File diff suppressed because it is too large Load Diff

File diff suppressed because it is too large Load Diff

@ -837,7 +837,7 @@
(symbol (lib_id "Transistor_FET:SiS454DN") (at 113.665 116.84 0) (mirror y)
(in_bom yes) (on_board yes)
(uuid 1231c43f-14ca-47cc-9675-e5654a66914e)
(property "Reference" "Q1" (id 0) (at 107.315 115.57 0))
(property "Reference" "Q6" (id 0) (at 107.315 115.57 0))
(property "Value" "SiSS80DN" (id 1) (at 108.585 117.475 0)
(effects (font (size 1.27 1.27)) (justify left))
)
@ -857,7 +857,7 @@
(symbol (lib_id "Transistor_FET:SiS454DN") (at 168.91 116.84 0) (mirror x)
(in_bom yes) (on_board yes)
(uuid 17ddf7e8-eb96-4a18-9066-e11ac3a15cf4)
(property "Reference" "Q2" (id 0) (at 175.26 115.57 0))
(property "Reference" "Q7" (id 0) (at 175.26 115.57 0))
(property "Value" "SiSS80DN" (id 1) (at 173.99 117.475 0)
(effects (font (size 1.27 1.27)) (justify left))
)
@ -877,7 +877,7 @@
(symbol (lib_id "Device:R") (at 117.475 91.44 90)
(in_bom yes) (on_board yes)
(uuid 192c29fe-4174-40bd-a33c-5a56fe839628)
(property "Reference" "R8" (id 0) (at 118.11 87.63 90))
(property "Reference" "R63" (id 0) (at 118.11 87.63 90))
(property "Value" "30k" (id 1) (at 117.475 89.535 90))
(property "Footprint" "Resistor_SMD:R_0603_1608Metric" (id 2) (at 117.475 93.218 90)
(effects (font (size 1.27 1.27)) hide)
@ -892,7 +892,7 @@
(symbol (lib_id "Device:C") (at 166.37 91.44 90)
(in_bom yes) (on_board yes)
(uuid 1a676e0a-4012-4c1c-9ef1-562c2faae053)
(property "Reference" "C50" (id 0) (at 165.7349 86.36 90)
(property "Reference" "C65" (id 0) (at 165.7349 86.36 90)
(effects (font (size 1.27 1.27)) (justify left))
)
(property "Value" "123nF" (id 1) (at 169.545 88.265 90)
@ -927,7 +927,7 @@
(symbol (lib_id "Device:C") (at 101.6 92.71 0)
(in_bom yes) (on_board yes)
(uuid 3ae5819c-1841-4d9f-b404-6f1058ae3a5f)
(property "Reference" "C20" (id 0) (at 104.775 92.7099 0)
(property "Reference" "C62" (id 0) (at 104.775 92.7099 0)
(effects (font (size 1.27 1.27)) (justify left))
)
(property "Value" "100nF" (id 1) (at 102.235 95.25 0)
@ -946,7 +946,7 @@
(symbol (lib_id "Device:R") (at 183.515 65.405 90)
(in_bom yes) (on_board yes)
(uuid 441d5e74-e8de-413e-8e56-906f5a5e6c53)
(property "Reference" "R48" (id 0) (at 183.515 60.96 90))
(property "Reference" "R67" (id 0) (at 183.515 60.96 90))
(property "Value" "200R" (id 1) (at 183.515 62.865 90))
(property "Footprint" "Inductor_SMD:L_0603_1608Metric" (id 2) (at 183.515 67.183 90)
(effects (font (size 1.27 1.27)) hide)
@ -977,7 +977,7 @@
(symbol (lib_id "power:GND") (at 101.6 99.06 0)
(in_bom yes) (on_board yes) (fields_autoplaced)
(uuid 53e26ade-bd9c-4446-97fa-2670d06dcf2a)
(property "Reference" "#PWR0158" (id 0) (at 101.6 105.41 0)
(property "Reference" "#PWR0196" (id 0) (at 101.6 105.41 0)
(effects (font (size 1.27 1.27)) hide)
)
(property "Value" "GND" (id 1) (at 101.6 102.87 0))
@ -993,7 +993,7 @@
(symbol (lib_id "power:PWR_FLAG") (at 101.6 81.28 0)
(in_bom yes) (on_board yes)
(uuid 71b2073a-7077-427a-8045-1bf51c525599)
(property "Reference" "#FLG0104" (id 0) (at 101.6 79.375 0)
(property "Reference" "#FLG0111" (id 0) (at 101.6 79.375 0)
(effects (font (size 1.27 1.27)) hide)
)
(property "Value" "PWR_FLAG" (id 1) (at 104.775 77.47 0))
@ -1009,7 +1009,7 @@
(symbol (lib_id "Device:R") (at 97.155 121.92 90)
(in_bom yes) (on_board yes)
(uuid 7668c40f-9ef7-464e-ae85-6d281af3ee93)
(property "Reference" "R7" (id 0) (at 97.155 125.73 90))
(property "Reference" "R62" (id 0) (at 97.155 125.73 90))
(property "Value" "10m" (id 1) (at 97.155 123.825 90))
(property "Footprint" "Resistor_SMD:R_0603_1608Metric" (id 2) (at 97.155 123.698 90)
(effects (font (size 1.27 1.27)) hide)
@ -1024,7 +1024,7 @@
(symbol (lib_id "Device:C") (at 161.925 106.68 90)
(in_bom yes) (on_board yes)
(uuid 79928b8a-8bc5-48fe-8c09-b41a51726282)
(property "Reference" "C49" (id 0) (at 165.0999 103.505 90)
(property "Reference" "C64" (id 0) (at 165.0999 103.505 90)
(effects (font (size 1.27 1.27)) (justify left))
)
(property "Value" "47nF" (id 1) (at 167.64 105.41 90)
@ -1043,7 +1043,7 @@
(symbol (lib_id "power:GND") (at 175.895 99.06 0)
(in_bom yes) (on_board yes)
(uuid 92aa3ac5-461e-4a43-803d-9ee73ccf5438)
(property "Reference" "#PWR0160" (id 0) (at 175.895 105.41 0)
(property "Reference" "#PWR0198" (id 0) (at 175.895 105.41 0)
(effects (font (size 1.27 1.27)) hide)
)
(property "Value" "GND" (id 1) (at 173.99 102.6794 0)
@ -1061,7 +1061,7 @@
(symbol (lib_id "power:PWR_FLAG") (at 111.125 107.315 0)
(in_bom yes) (on_board yes) (fields_autoplaced)
(uuid 9e489abf-02a5-4f2c-b016-3c37c8428006)
(property "Reference" "#FLG0102" (id 0) (at 111.125 105.41 0)
(property "Reference" "#FLG0110" (id 0) (at 111.125 105.41 0)
(effects (font (size 1.27 1.27)) hide)
)
(property "Value" "~" (id 1) (at 113.665 106.2354 0)
@ -1079,7 +1079,7 @@
(symbol (lib_id "Device:R") (at 182.245 121.92 270)
(in_bom yes) (on_board yes)
(uuid b52e8e8e-da58-4f75-bc39-6f4fede7a32c)
(property "Reference" "R47" (id 0) (at 182.245 125.73 90))
(property "Reference" "R64" (id 0) (at 182.245 125.73 90))
(property "Value" "10m" (id 1) (at 182.245 123.825 90))
(property "Footprint" "Resistor_SMD:R_0603_1608Metric" (id 2) (at 182.245 120.142 90)
(effects (font (size 1.27 1.27)) hide)
@ -1094,7 +1094,7 @@
(symbol (lib_id "power:PWR_FLAG") (at 171.45 106.68 0)
(in_bom yes) (on_board yes) (fields_autoplaced)
(uuid c6054f26-cf31-40c9-8cfb-713768c32b4a)
(property "Reference" "#FLG0105" (id 0) (at 171.45 104.775 0)
(property "Reference" "#FLG0112" (id 0) (at 171.45 104.775 0)
(effects (font (size 1.27 1.27)) hide)
)
(property "Value" "~" (id 1) (at 171.45 102.87 0))
@ -1126,7 +1126,7 @@
(symbol (lib_id "Device:LED") (at 169.545 65.405 0)
(in_bom yes) (on_board yes) (fields_autoplaced)
(uuid cdfa9e5f-661f-4cfc-ac79-74c1592e7e47)
(property "Reference" "D6" (id 0) (at 169.3545 60.96 0))
(property "Reference" "D8" (id 0) (at 169.3545 60.96 0))
(property "Value" "LED" (id 1) (at 169.545 67.945 0))
(property "Footprint" "LED_SMD:LED_0603_1608Metric" (id 2) (at 169.545 65.405 0)
(effects (font (size 1.27 1.27)) hide)
@ -1157,7 +1157,7 @@
(symbol (lib_id "Power_Management:LTC4370xDE") (at 142.875 106.68 0)
(in_bom yes) (on_board yes)
(uuid dd4673e5-88b8-4bb8-94af-40b6837b93f2)
(property "Reference" "U3" (id 0) (at 144.7799 85.09 0)
(property "Reference" "U19" (id 0) (at 144.7799 85.09 0)
(effects (font (size 1.27 1.27)) (justify left))
)
(property "Value" "LTC4370xDE" (id 1) (at 144.7799 87.63 0)
@ -1191,7 +1191,7 @@
(symbol (lib_id "power:GND") (at 145.415 140.335 0)
(in_bom yes) (on_board yes) (fields_autoplaced)
(uuid dec39de5-aafc-441f-a04c-fb269706ed95)
(property "Reference" "#PWR0159" (id 0) (at 145.415 146.685 0)
(property "Reference" "#PWR0197" (id 0) (at 145.415 146.685 0)
(effects (font (size 1.27 1.27)) hide)
)
(property "Value" "GND" (id 1) (at 145.415 144.145 0))
@ -1207,7 +1207,7 @@
(symbol (lib_id "Device:C") (at 121.285 106.68 90)
(in_bom yes) (on_board yes)
(uuid e0e8a56c-3d12-4e7d-a385-ce2224df7688)
(property "Reference" "C35" (id 0) (at 120.0149 103.505 90)
(property "Reference" "C63" (id 0) (at 120.0149 103.505 90)
(effects (font (size 1.27 1.27)) (justify left))
)
(property "Value" "47nF" (id 1) (at 120.015 105.41 90)

Loading…
Cancel
Save