COMM: Review - round 2

This commit is contained in:
Petr Malanik
2021-12-02 23:56:25 +01:00
committed by Štěpán Rydlo
parent ee542cd0a7
commit c7a291d89b
5 changed files with 160 additions and 42 deletions

View File

@ -1833,7 +1833,10 @@
(junction (at 260.35 150.495) (diameter 0.9144) (color 0 0 0 0))
(junction (at 260.35 160.655) (diameter 0.9144) (color 0 0 0 0))
(no_connect (at 15.24 184.15) (uuid 6cfe5ab9-2e1d-4eff-a4e7-10b69327c163))
(no_connect (at 33.655 44.45) (uuid c20b32bc-16b5-4a14-abcf-ed25ee2b1b4a))
(no_connect (at 43.18 139.7) (uuid 5522011f-5171-487b-b668-87d932989e66))
(no_connect (at 67.31 151.13) (uuid d4e44e4f-9ffb-44ad-8264-36db91914386))
(no_connect (at 95.885 43.815) (uuid 58aa9bf0-2b8d-4f09-9852-144033041c8b))
(no_connect (at 113.665 90.805) (uuid f8dfa690-166a-483b-b0e7-099c24dfd9cc))
(no_connect (at 113.665 93.345) (uuid f8dfa690-166a-483b-b0e7-099c24dfd9cc))
@ -1841,7 +1844,7 @@
(no_connect (at 123.825 78.105) (uuid f8dfa690-166a-483b-b0e7-099c24dfd9cc))
(no_connect (at 146.685 32.385) (uuid 8740f14b-f9b3-44fc-bc70-0ab09c84cf20))
(no_connect (at 160.02 137.16) (uuid 61e217e3-f875-4369-b3db-768ec349b53a))
(no_connect (at 226.06 39.37) (uuid 290eeba7-3b69-4d3e-831b-508c61b337ce))
(no_connect (at 250.19 40.64) (uuid 2aee8c6d-b65e-4901-9fb5-c09a3aba8e97))
(wire (pts (xy 13.335 162.56) (xy 37.465 162.56))
(stroke (width 0) (type solid) (color 0 0 0 0))
@ -2713,6 +2716,11 @@
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid 00a52d88-8800-45e5-a63c-b26231316755)
)
(text "There probably should not be any\ncapacitors on USB data lines"
(at 16.51 187.96 0)
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid 2ebba203-12a8-42e2-b947-e5053bbc91e2)
)
(text "Reset button is separated from Watchdog, to enable\nreset by button when watchdog is disconnected"
(at 17.145 76.2 0)
(effects (font (size 1.27 1.27)) (justify left bottom))
@ -2722,6 +2730,11 @@
(effects (font (size 2 2) (thickness 0.4) bold) (justify left bottom))
(uuid a8c311b3-ed81-4119-b589-93a5c63e6751)
)
(text "Value of solder jumper\nshould be his purpose\nEx: USB_SEL"
(at 44.45 144.78 0)
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid f3390598-4ea5-455e-801e-25ef06ec087f)
)
(text "Reset" (at 45.085 71.12 0)
(effects (font (size 2 2) (thickness 0.4) bold) (justify left bottom))
(uuid 480c3375-4523-48e7-98c1-d9b31b518a4c)
@ -2734,6 +2747,10 @@
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid f5dcdd11-ce97-4b1f-ba59-c27cf847f283)
)
(text "USB wires order" (at 68.58 152.4 0)
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid b1b5ee04-8811-4c7e-ab51-d396d53c9eee)
)
(text "High-Speed oscillator" (at 85.725 171.45 0)
(effects (font (size 2 2) (thickness 0.4) bold) (justify left bottom))
(uuid 7cd06a7f-06fa-4cd5-a879-1226b343440f)
@ -2754,7 +2771,8 @@
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid f7d9b2ec-c0df-4662-90c8-9909c84b451c)
)
(text "USB should be\ndifferential" (at 161.29 139.7 0)
(text "USB should be differential, adjust wire naming to that\nNew version probably have support for P/N -> Check that!!\n"
(at 172.72 151.13 90)
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid 46e5f71d-34ce-43f8-ba05-1401f11d9e0d)
)
@ -2776,10 +2794,6 @@
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid b241b1f5-8a83-4767-948f-d4633a553b85)
)
(text "Insufficient decoupling capacitors" (at 227.33 40.64 0)
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid 30ca5fa1-f582-4220-bbd1-2b26bb54cee9)
)
(text "Decoupled MCU capacitors" (at 228.6 24.13 0)
(effects (font (size 1.5 1.5)) (justify left bottom))
(uuid 7b7658d3-0141-4ca6-bd5f-273daa58cfc3)
@ -2796,6 +2810,10 @@
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid f89a1843-75f1-472c-91bd-d4717783d54d)
)
(text "Why VSS label on GND,\nconfusing as hell" (at 251.46 44.45 0)
(effects (font (size 1.27 1.27)) (justify left bottom))
(uuid 20126183-2495-408b-8fc0-0e9e229de270)
)
(label "USB_DBG_DP" (at 13.335 162.56 0)
(effects (font (size 1.27 1.27)) (justify left bottom))