From af09f9904afb82ea236196bb37bca716293db3d0 Mon Sep 17 00:00:00 2001 From: Petr Malanik Date: Thu, 4 Nov 2021 23:28:16 +0100 Subject: [PATCH] COMM: Review - round 1 --- modules/Communication/OpenLST.kicad_sch | 40 +++++++++-- .../Communication/battSwitch_3V3.kicad_sch | 11 +++ modules/Communication/battSwitch_5V.kicad_sch | 46 ++++++++++++ modules/Communication/comm.kicad_prl | 3 +- modules/Communication/comm.kicad_sch | 70 +++++++++++++++---- modules/Communication/gps_module.kicad_sch | 22 ++++++ .../Communication/hf_transmitter.kicad_sch | 33 ++++++++- modules/Communication/mcu_comm.kicad_sch | 45 ++++++++++++ 8 files changed, 248 insertions(+), 22 deletions(-) diff --git a/modules/Communication/OpenLST.kicad_sch b/modules/Communication/OpenLST.kicad_sch index b648013..6ab231a 100644 --- a/modules/Communication/OpenLST.kicad_sch +++ b/modules/Communication/OpenLST.kicad_sch @@ -1731,11 +1731,17 @@ (no_connect (at 31.75 148.59) (uuid bd1c0dc9-9dab-4a8e-960f-1be5fb624ba2)) (no_connect (at 31.75 153.67) (uuid 2835a888-a3b6-4aa1-bcc0-c16b4cc0a324)) + (no_connect (at 34.29 49.53) (uuid 4ae87010-1994-40c2-a0d9-176e9d8e05b5)) + (no_connect (at 35.56 181.61) (uuid a810df70-e42e-4b03-8dae-0a083d5e1afc)) + (no_connect (at 40.64 29.21) (uuid 1fe0feb1-2a3d-4d7d-ae9c-0e09d8d8aae5)) + (no_connect (at 40.64 33.02) (uuid 431f45c9-33a6-4cd6-aa8e-0cfd43863de2)) + (no_connect (at 40.64 36.83) (uuid dd9d7c69-42a8-4414-b13f-eb9c4e26c22d)) (no_connect (at 44.45 148.59) (uuid 1ed7ac17-6c61-4e9a-a0a5-ce3e8a7df851)) (no_connect (at 44.45 151.13) (uuid edbe6432-cdc2-4880-a5a5-187633fe248e)) (no_connect (at 44.45 153.67) (uuid ebb02fa3-ca97-44d1-9429-1497c5b0f1f5)) (no_connect (at 90.17 91.44) (uuid 07da0a64-f33b-469a-973d-c9b25dd8db9e)) (no_connect (at 90.17 102.87) (uuid 39387e56-b387-4959-94ce-73d8a78be2b3)) + (no_connect (at 201.93 166.37) (uuid 2772ed42-5aa2-4f66-9358-9fc674eff10a)) (no_connect (at 251.46 97.79) (uuid f69c727c-cf15-44ef-bbb7-55c493ba44b2)) (no_connect (at 251.46 100.33) (uuid ee771831-bd6c-4140-95ae-f4245c540cb3)) (no_connect (at 251.46 102.87) (uuid db1a56a6-b7b9-4146-8cd1-d658900b5370)) @@ -2897,6 +2903,28 @@ (effects (font (size 1.524 1.524) (thickness 0.3048) bold) (justify left bottom)) (uuid ccee3f73-93ef-4a61-8c4d-beda8616c34a) ) + (text "Local labels connected to global in\nhierarchical sheet which is not source" + (at 34.29 186.69 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid f6262eb5-73b0-4a96-b2ef-40b7d4af07bd) + ) + (text "Missing power flag" (at 35.56 50.8 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid ca09b965-e54f-4e78-9f0a-af753107e31d) + ) + (text "All ICs are unavailable!" (at 41.91 30.48 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid cfacdbd0-ac1c-4964-90ea-74f51fe0dcac) + ) + (text "Many unconnected line near to labels" (at 41.91 34.29 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 0817da86-6f17-4efe-b768-1b1639a816f0) + ) + (text "In case of implementation further review is required" + (at 41.91 38.1 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid faf1fc97-886a-4a95-9565-cd58655df37e) + ) (text "TODO: add pads for switcher as alternate to LDO" (at 62.23 201.93 0) (effects (font (size 1.524 1.524) (thickness 0.3048) bold italic) (justify left bottom)) (uuid 8b62885f-f71e-49f9-bacd-64d5458e66de) @@ -2929,6 +2957,10 @@ (effects (font (size 1.524 1.524) (thickness 0.3048) bold) (justify left bottom)) (uuid f9e0c7cf-ef26-4b9a-b96f-c1382c82b5cd) ) + (text "male connector on PCB?" (at 203.2 167.64 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 45518676-2845-421a-8e0b-c1df2d6d60e5) + ) (text "VAPC = 2.26 V" (at 219.71 36.83 0) (effects (font (size 1.524 1.524)) (justify left bottom)) (uuid 34c5926e-f214-4a7d-ad97-125a4f483c45) @@ -2998,10 +3030,6 @@ (effects (font (size 1.524 1.524)) (justify left bottom)) (uuid f45aad61-3a75-4dbb-bb93-151f236d5751) ) - (label "PROG_DD" (at 45.72 156.21 0) - (effects (font (size 1.524 1.524)) (justify left bottom)) - (uuid db21cdd9-7921-4928-8603-ee2ce377f423) - ) (label "AN0" (at 46.99 92.71 0) (effects (font (size 1.524 1.524)) (justify left bottom)) (uuid c327ff34-50e3-4475-871b-c769d2076776) @@ -3010,6 +3038,10 @@ (effects (font (size 1.524 1.524)) (justify left bottom)) (uuid a62d8abc-3835-4d10-a06a-c20db88783c1) ) + (label "PROG_DD" (at 46.99 156.21 0) + (effects (font (size 1.524 1.524)) (justify left bottom)) + (uuid db21cdd9-7921-4928-8603-ee2ce377f423) + ) (label "LST_TX_MODE" (at 85.09 152.4 0) (effects (font (size 1.524 1.524)) (justify left bottom)) (uuid 23c59a0e-0d81-4218-a9ec-65148236eae8) diff --git a/modules/Communication/battSwitch_3V3.kicad_sch b/modules/Communication/battSwitch_3V3.kicad_sch index 321649d..deb9ae1 100644 --- a/modules/Communication/battSwitch_3V3.kicad_sch +++ b/modules/Communication/battSwitch_3V3.kicad_sch @@ -208,7 +208,9 @@ (junction (at 171.45 95.885) (diameter 1.016) (color 0 0 0 0)) (junction (at 181.61 95.885) (diameter 1.016) (color 0 0 0 0)) + (no_connect (at 119.38 78.74) (uuid 3521f79d-f717-491e-8530-0f66d18a943b)) (no_connect (at 140.97 125.095) (uuid 6a0e23ab-5569-4fab-acad-85e54eeabe3a)) + (no_connect (at 147.32 128.27) (uuid 3a85cd66-8cd8-447c-8be7-a54645d2f0c4)) (wire (pts (xy 88.265 113.665) (xy 101.6 113.665)) (stroke (width 0) (type solid) (color 0 0 0 0)) @@ -319,6 +321,15 @@ (uuid 81a7a38d-0194-4e9a-93c8-1def062c0fdc) ) + (text "Include same as notes as in 5V switch" (at 120.65 80.01 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 08f17162-b52b-4580-88e4-210d682abe50) + ) + (text "Minimal supply voltage is 4.5C" (at 148.59 129.54 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid b1dfd62d-7fab-4077-94c9-bc60efa47f5f) + ) + (label "ADJ" (at 116.84 120.015 180) (effects (font (size 1.27 1.27)) (justify right bottom)) (uuid 22d525b1-78a4-47fe-9a8e-55ff30e1e201) diff --git a/modules/Communication/battSwitch_5V.kicad_sch b/modules/Communication/battSwitch_5V.kicad_sch index eb4c94b..f67830f 100644 --- a/modules/Communication/battSwitch_5V.kicad_sch +++ b/modules/Communication/battSwitch_5V.kicad_sch @@ -208,7 +208,16 @@ (junction (at 171.45 95.885) (diameter 1.016) (color 0 0 0 0)) (junction (at 181.61 95.885) (diameter 1.016) (color 0 0 0 0)) + (no_connect (at 82.55 116.84) (uuid fea28a14-4988-4409-9d95-863fcc88cf78)) + (no_connect (at 92.71 92.71) (uuid 609cc358-59f6-48d4-b713-ddcc4d3c4fba)) + (no_connect (at 133.35 134.62) (uuid 553ab76c-1fc6-4168-a26f-c89143452248)) + (no_connect (at 134.62 88.9) (uuid c45395bd-2971-4f27-bac2-ed2cddac1503)) + (no_connect (at 139.7 129.54) (uuid b090782e-9f32-4856-9b68-6b6f01d96bcf)) (no_connect (at 140.97 125.095) (uuid 6a0e23ab-5569-4fab-acad-85e54eeabe3a)) + (no_connect (at 144.78 125.73) (uuid d7489fde-35b5-4e16-bbca-8ffa00a9856c)) + (no_connect (at 151.13 121.92) (uuid dfc62c5d-6c7e-4ba3-91a0-2073fb09587c)) + (no_connect (at 175.26 115.57) (uuid c42732e5-10d8-41a6-87b4-d25a69d97105)) + (no_connect (at 187.96 92.71) (uuid 879309eb-1119-4d3a-af6f-f4a7a1c0f580)) (wire (pts (xy 88.265 113.665) (xy 101.6 113.665)) (stroke (width 0) (type solid) (color 0 0 0 0)) @@ -319,6 +328,43 @@ (uuid 81a7a38d-0194-4e9a-93c8-1def062c0fdc) ) + (text "Unconnected" (at 83.82 118.11 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 46242efe-1c9a-4889-8867-9972dd0e7854) + ) + (text "Missing power flag" (at 93.98 92.71 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 4df38876-ce58-4dfc-afb2-00b627c20778) + ) + (text "Not driven GND" (at 134.62 135.89 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid e72bef62-e9be-4b01-9df5-71b6638bfaf8) + ) + (text "Wrong unit -> 470nF" (at 135.89 90.17 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 3e858f13-d51b-4011-92ed-c4174df077b6) + ) + (text "Circuit is not available" (at 140.97 130.81 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 86ca8626-859a-4f12-9058-f3a6f2a52b38) + ) + (text "LS bus is not connected to another LS controller" (at 146.05 127 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid e3aba430-53a9-4a20-abe6-bd69bf3a96dc) + ) + (text "Inconsistend decimal separator" (at 152.4 123.19 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid bfe3fb40-0a63-40ad-beb9-6d3917d4710f) + ) + (text "Missing power flag" (at 176.53 115.57 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 20d37cd6-7501-48ea-989b-e3083eb9cc14) + ) + (text "Missing power flag" (at 189.23 92.71 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 2c99f31b-5c8a-47d6-8e67-7f552a1bcba6) + ) + (label "ADJ" (at 116.84 120.015 180) (effects (font (size 1.27 1.27)) (justify right bottom)) (uuid 22d525b1-78a4-47fe-9a8e-55ff30e1e201) diff --git a/modules/Communication/comm.kicad_prl b/modules/Communication/comm.kicad_prl index 923c8d4..82fb7b3 100644 --- a/modules/Communication/comm.kicad_prl +++ b/modules/Communication/comm.kicad_prl @@ -1,7 +1,7 @@ { "board": { "active_layer": 0, - "active_layer_preset": "Všechny vrstvy", + "active_layer_preset": "", "auto_track_width": true, "hidden_nets": [], "high_contrast_mode": 0, @@ -37,7 +37,6 @@ 8, 9, 10, - 11, 12, 13, 14, diff --git a/modules/Communication/comm.kicad_sch b/modules/Communication/comm.kicad_sch index bbee14f..a5913df 100644 --- a/modules/Communication/comm.kicad_sch +++ b/modules/Communication/comm.kicad_sch @@ -101,6 +101,15 @@ (junction (at 72.39 106.045) (diameter 1.016) (color 0 0 0 0)) (junction (at 140.97 63.5) (diameter 1.016) (color 0 0 0 0)) + (no_connect (at 52.07 124.46) (uuid 68bc0a7e-8b7f-4f63-a84f-9b7d2ff210bb)) + (no_connect (at 91.44 40.64) (uuid 75edfa25-211c-49c2-9c39-4b0747e5d7aa)) + (no_connect (at 127 140.97) (uuid 01191fff-702e-4722-88d7-a5a9a1781d7d)) + (no_connect (at 146.05 30.48) (uuid 9c380ec5-b2f4-4656-afbe-6d87c6f19663)) + (no_connect (at 161.29 53.34) (uuid 7d710b57-e226-4acf-8e47-06a008eda7ee)) + (no_connect (at 179.07 167.64) (uuid 4351eb10-e4e8-4220-9b17-52cdc0b31b52)) + (no_connect (at 179.07 171.45) (uuid b6a7f470-b564-4bef-aeb2-bd6c8ba8d06f)) + (no_connect (at 179.07 175.26) (uuid 11a30179-e77f-4e9a-ad87-78058c301779)) + (wire (pts (xy 69.215 111.76) (xy 83.82 111.76)) (stroke (width 0) (type solid) (color 0 0 0 0)) (uuid 5e8c69c5-5877-4249-959b-d379727ec6d2) @@ -534,6 +543,39 @@ (uuid 626db29b-b8f5-4340-8f5a-56eb4fa25e4b) ) + (text "Connectors from\nuncommon library" (at 53.34 127 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 2fceaaab-5133-4282-9b5e-e546f659fca4) + ) + (text "Power lines should use symbols not wires" (at 92.71 41.91 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 68872a48-3d64-4ee4-a3be-2f5980d7094e) + ) + (text "Inconsistent Interrupt naming" (at 128.27 142.24 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid c03bbd66-d85a-40f4-8caf-0dd4135e5d5d) + ) + (text "No regulation or output for load sharing circuits" (at 147.32 31.75 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid a34e7e12-0040-4b7e-b519-30d832eca581) + ) + (text "Invalid hierarchy\nOne sheet - two schematics" (at 162.56 55.88 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 69612895-fe3c-4123-a1ac-b54815d7546d) + ) + (text "Empty sheet description" (at 180.34 168.91 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 610ac8c9-7589-40ef-8a04-3b5293f27389) + ) + (text "No test points at all!" (at 180.34 172.72 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 131093de-2eec-49b2-ae40-5779c0a3ede7) + ) + (text "Many ERC violation" (at 180.34 176.53 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 4934253c-a908-4d5f-a7d4-2e5b05b79f9d) + ) + (symbol (lib_id "power:GND") (at 65.405 106.68 180) (unit 1) (in_bom yes) (on_board yes) (fields_autoplaced) (uuid 50b604f6-83fc-4f22-8998-ccc95e521b8a) @@ -624,10 +666,10 @@ (stroke (width 0.1524) (type solid) (color 0 0 0 0)) (fill (color 0 0 0 0.0000)) (uuid 0335b19b-f69a-4698-b41d-d454ea335718) - (property "Název listu" "Battery switch" (id 0) (at 145.415 58.3434 0) + (property "Sheet name" "Battery switch" (id 0) (at 145.415 58.3434 0) (effects (font (size 1.27 1.27)) (justify left bottom)) ) - (property "Soubor listu" "battSwitch_3V3.kicad_sch" (id 1) (at 145.415 68.5296 0) + (property "Sheet file" "battSwitch_3V3.kicad_sch" (id 1) (at 145.415 68.5296 0) (effects (font (size 1.27 1.27)) (justify left top)) ) (pin "+3V3 out" input (at 145.415 63.5 180) @@ -648,10 +690,10 @@ (stroke (width 0.1524) (type solid) (color 0 0 0 0)) (fill (color 0 0 0 0.0000)) (uuid 3c14080c-daae-427f-8672-ca62b5c33dad) - (property "Název listu" "Battery switch1" (id 0) (at 145.415 37.3884 0) + (property "Sheet name" "Battery switch1" (id 0) (at 145.415 37.3884 0) (effects (font (size 1.27 1.27)) (justify left bottom)) ) - (property "Soubor listu" "battSwitch_5V.kicad_sch" (id 1) (at 145.415 47.5746 0) + (property "Sheet file" "battSwitch_5V.kicad_sch" (id 1) (at 145.415 47.5746 0) (effects (font (size 1.27 1.27)) (justify left top)) ) (pin "EPS#1_5V" input (at 175.26 40.64 0) @@ -672,10 +714,10 @@ (stroke (width 0.1524) (type solid) (color 0 0 0 0)) (fill (color 0 0 0 0.0000)) (uuid 135894dc-6710-4561-8073-567533e9f424) - (property "Název listu" "GPS Module" (id 0) (at 83.82 95.1734 0) + (property "Sheet name" "GPS Module" (id 0) (at 83.82 95.1734 0) (effects (font (size 1.27 1.27)) (justify left bottom)) ) - (property "Soubor listu" "gps_module.kicad_sch" (id 1) (at 83.82 119.3296 0) + (property "Sheet file" "gps_module.kicad_sch" (id 1) (at 83.82 119.3296 0) (effects (font (size 1.27 1.27)) (justify left top)) ) (pin "3V3" input (at 83.82 106.045 180) @@ -716,10 +758,10 @@ (stroke (width 0.1524) (type solid) (color 0 0 0 0)) (fill (color 0 0 0 0.0000)) (uuid 81a5172c-b171-400d-8856-41d6e486bdd1) - (property "Název listu" "MCU" (id 0) (at 136.525 88.8234 0) + (property "Sheet name" "MCU" (id 0) (at 136.525 88.8234 0) (effects (font (size 1.27 1.27)) (justify left bottom)) ) - (property "Soubor listu" "mcu_comm.kicad_sch" (id 1) (at 136.525 133.2996 0) + (property "Sheet file" "mcu_comm.kicad_sch" (id 1) (at 136.525 133.2996 0) (effects (font (size 1.27 1.27)) (justify left top)) ) (pin "RS_485_A" input (at 169.545 108.585 0) @@ -836,10 +878,10 @@ (stroke (width 0.1524) (type solid) (color 0 0 0 0)) (fill (color 0 0 0 0.0000)) (uuid 829b2795-9702-4633-a078-e2998d6d9402) - (property "Název listu" "OpenLST (Beacon)" (id 0) (at 81.915 59.6134 0) + (property "Sheet name" "OpenLST (Beacon)" (id 0) (at 81.915 59.6134 0) (effects (font (size 1.27 1.27)) (justify left bottom)) ) - (property "Soubor listu" "OpenLST.kicad_sch" (id 1) (at 81.915 84.4046 0) + (property "Sheet file" "OpenLST.kicad_sch" (id 1) (at 81.915 84.4046 0) (effects (font (size 1.27 1.27)) (justify left top)) ) (pin "5V" input (at 81.915 73.66 180) @@ -872,10 +914,10 @@ (stroke (width 0.1524) (type solid) (color 0 0 0 0)) (fill (color 0 0 0 0.0000)) (uuid 3006f49f-d72b-4219-8dea-bda42cf88e84) - (property "Název listu" "Stack Connector" (id 0) (at 207.645 59.6134 0) + (property "Sheet name" "Stack Connector" (id 0) (at 207.645 59.6134 0) (effects (font (size 1.27 1.27)) (justify left bottom)) ) - (property "Soubor listu" "Stack_connector.kicad_sch" (id 1) (at 207.645 116.7896 0) + (property "Sheet file" "Stack_connector.kicad_sch" (id 1) (at 207.645 116.7896 0) (effects (font (size 1.27 1.27)) (justify left top)) ) (pin "CAN_H" input (at 207.645 88.265 180) @@ -940,10 +982,10 @@ (stroke (width 0.1524) (type solid) (color 0 0 0 0)) (fill (color 0 0 0 0.0000)) (uuid a345038c-0e2c-4410-9183-a80a047c8766) - (property "Název listu" "nRF Transceiver" (id 0) (at 84.455 130.7334 0) + (property "Sheet name" "nRF Transceiver" (id 0) (at 84.455 130.7334 0) (effects (font (size 1.27 1.27)) (justify left bottom)) ) - (property "Soubor listu" "hf_transmitter.kicad_sch" (id 1) (at 84.455 151.0796 0) + (property "Sheet file" "hf_transmitter.kicad_sch" (id 1) (at 84.455 151.0796 0) (effects (font (size 1.27 1.27)) (justify left top)) ) (pin "RF I{slash}O" input (at 84.455 142.875 180) diff --git a/modules/Communication/gps_module.kicad_sch b/modules/Communication/gps_module.kicad_sch index 63ad9a8..3ee5e5c 100644 --- a/modules/Communication/gps_module.kicad_sch +++ b/modules/Communication/gps_module.kicad_sch @@ -172,14 +172,19 @@ ) ) + (junction (at 162.56 57.15) (diameter 1.016) (color 0 0 0 0)) (no_connect (at 147.32 67.945) (uuid 85201180-d2ed-4b0d-81b0-9e79da370ca6)) (no_connect (at 147.32 70.485) (uuid 85201180-d2ed-4b0d-81b0-9e79da370ca6)) (no_connect (at 147.32 95.885) (uuid 4009b76d-4e12-41c2-8abc-3c909f129ef1)) (no_connect (at 170.18 60.325) (uuid 1b73e5f0-4e7e-41b1-9c36-49ff1ba71bba)) + (no_connect (at 175.26 46.99) (uuid 9b815f68-a45a-4127-9423-cdd83a06ce58)) + (no_connect (at 175.26 53.34) (uuid a9289e3e-6f9e-45ad-b6b7-28ae328600f3)) (no_connect (at 182.88 78.105) (uuid 0e6bdf56-5557-47ab-807c-4c8fd6a29f11)) (no_connect (at 182.88 90.805) (uuid 640c81af-5b52-4930-825d-dea52c971932)) + (no_connect (at 193.04 73.66) (uuid 98eb6060-9d50-40a5-94eb-83c0e8b85566)) + (no_connect (at 193.04 77.47) (uuid 4ff146fd-0bfd-4102-8960-a7fdb5091651)) (wire (pts (xy 137.795 83.185) (xy 147.32 83.185)) (stroke (width 0) (type solid) (color 0 0 0 0)) @@ -250,6 +255,23 @@ (effects (font (size 1.27 1.27)) (justify left bottom)) (uuid cdf36631-0b51-4d27-94ca-d6a112c60208) ) + (text "Missing Capacitor on Power supply\n(low ESR)" (at 176.53 50.8 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 998aa15a-aab2-47f8-95be-c3a0a284deb3) + ) + (text "No bypass capacitors" (at 176.53 54.61 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 0b42d314-3a79-448a-ae45-66bbce0c5e0c) + ) + (text "Missing information about antenna routing" (at 194.31 74.93 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 191e82d5-e216-4e16-9901-6cf435ad0fb5) + ) + (text "No antenna specification (only patch is not sufficient)\nExternal LNA or active antena should be used" + (at 194.31 80.01 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 912f6073-bfe7-4b15-b52d-9d1b9b3cb0c0) + ) (hierarchical_label "SDA" (shape input) (at 137.795 83.185 180) (effects (font (size 1.27 1.27)) (justify right)) diff --git a/modules/Communication/hf_transmitter.kicad_sch b/modules/Communication/hf_transmitter.kicad_sch index 726219f..a43c37a 100644 --- a/modules/Communication/hf_transmitter.kicad_sch +++ b/modules/Communication/hf_transmitter.kicad_sch @@ -373,6 +373,7 @@ ) ) + (junction (at 161.29 68.58) (diameter 1.016) (color 0 0 0 0)) (junction (at 170.815 68.58) (diameter 1.016) (color 0 0 0 0)) (junction (at 173.99 114.935) (diameter 1.016) (color 0 0 0 0)) @@ -393,6 +394,12 @@ (junction (at 248.92 100.965) (diameter 1.016) (color 0 0 0 0)) (junction (at 260.985 88.265) (diameter 1.016) (color 0 0 0 0)) + (no_connect (at 161.29 52.07) (uuid b27c77d1-8477-4e54-9a4b-5f0cda8ef123)) + (no_connect (at 224.79 48.26) (uuid 17581ce2-2586-4cff-8d36-414362c0c2f6)) + (no_connect (at 224.79 52.07) (uuid 5828b0e2-83e3-44fc-b317-a9acb25f2a7f)) + (no_connect (at 229.87 80.01) (uuid 1ec21823-42ad-42ca-8e93-fa855b0466c8)) + (no_connect (at 252.73 92.71) (uuid dab6cce1-28a1-41cd-8447-2072483b5f1c)) + (wire (pts (xy 149.225 61.595) (xy 149.225 68.58)) (stroke (width 0) (type solid) (color 0 0 0 0)) (uuid 96482b02-6b2f-4ff7-8cf1-49f64d697d14) @@ -638,6 +645,28 @@ (uuid fc45c970-057f-45f5-8110-63817424f990) ) + (text "No infomation about capacitor placement ->\nTwo capacitors, 3 power inputs\n" + (at 162.56 54.61 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 2dba63b1-340e-4a54-a67f-2df370b81af2) + ) + (text "Ground upwards? c'mon" (at 226.06 49.53 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 957f290b-a858-46f3-9890-fcd9ed8a12a7) + ) + (text "Some GND have labels some not?" (at 226.06 53.34 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid a62ae571-4c40-4ca6-9d7a-351af43cf371) + ) + (text "Coil orientation\ncoil pad numbering?" (at 231.14 82.55 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 03270deb-1330-4bc4-a9fd-8718cfe5b9a5) + ) + (text "Missing information about antena routing" (at 254 93.98 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 6baa2896-4452-4d58-96cb-d5373ccbb357) + ) + (hierarchical_label "3V3" (shape input) (at 149.225 61.595 90) (effects (font (size 1.27 1.27)) (justify left)) (uuid fa4f1af4-35a1-4e43-80ff-d24cd4e474fe) @@ -736,12 +765,12 @@ ) (symbol (lib_id "power:GND") (at 227.965 58.42 180) (unit 1) - (in_bom yes) (on_board yes) (fields_autoplaced) + (in_bom yes) (on_board yes) (uuid 719dedba-ec4c-472a-9501-c59530e0fd4f) (property "Reference" "#PWR0114" (id 0) (at 227.965 52.07 0) (effects (font (size 1.27 1.27)) hide) ) - (property "Value" "~" (id 1) (at 227.965 54.61 0)) + (property "Value" "~" (id 1) (at 227.965 50.8 0)) (property "Footprint" "" (id 2) (at 227.965 58.42 0) (effects (font (size 1.27 1.27)) hide) ) diff --git a/modules/Communication/mcu_comm.kicad_sch b/modules/Communication/mcu_comm.kicad_sch index b9990f9..db49cb1 100644 --- a/modules/Communication/mcu_comm.kicad_sch +++ b/modules/Communication/mcu_comm.kicad_sch @@ -1343,14 +1343,23 @@ (junction (at 260.35 150.495) (diameter 0.9144) (color 0 0 0 0)) (junction (at 260.35 160.655) (diameter 0.9144) (color 0 0 0 0)) + (no_connect (at 17.78 168.91) (uuid 5dcc0194-6451-4b0e-89d8-ff4be5c612f3)) + (no_connect (at 17.78 172.72) (uuid 216d93fe-403b-4581-a39c-3bc7b3edb777)) + (no_connect (at 17.78 193.04) (uuid 2bb93dcf-3fb8-41e9-a2aa-cf32ba54c7ba)) + (no_connect (at 33.02 132.08) (uuid e9fa4ef4-6ae1-4259-ae77-713cffe01c05)) (no_connect (at 33.655 44.45) (uuid c20b32bc-16b5-4a14-abcf-ed25ee2b1b4a)) + (no_connect (at 81.28 151.13) (uuid 2205b73b-410a-4c1b-b01b-242e0f185eff)) (no_connect (at 95.885 43.815) (uuid 58aa9bf0-2b8d-4f09-9852-144033041c8b)) (no_connect (at 113.665 90.805) (uuid f8dfa690-166a-483b-b0e7-099c24dfd9cc)) (no_connect (at 113.665 93.345) (uuid f8dfa690-166a-483b-b0e7-099c24dfd9cc)) (no_connect (at 113.665 103.505) (uuid e7c1b842-5cee-4c9d-b4d6-63b5af7fc3ae)) (no_connect (at 123.825 78.105) (uuid f8dfa690-166a-483b-b0e7-099c24dfd9cc)) + (no_connect (at 132.08 72.39) (uuid 0846652a-932c-43a0-90cb-b326d89ae2f0)) (no_connect (at 133.985 78.105) (uuid f8dfa690-166a-483b-b0e7-099c24dfd9cc)) (no_connect (at 146.685 32.385) (uuid 8740f14b-f9b3-44fc-bc70-0ab09c84cf20)) + (no_connect (at 152.4 21.59) (uuid eb09c624-7097-402f-ba1e-09aacdde77a5)) + (no_connect (at 160.02 137.16) (uuid 61e217e3-f875-4369-b3db-768ec349b53a)) + (no_connect (at 226.06 39.37) (uuid 290eeba7-3b69-4d3e-831b-508c61b337ce)) (wire (pts (xy 17.145 180.34) (xy 32.385 180.34)) (stroke (width 0) (type solid) (color 0 0 0 0)) @@ -2031,10 +2040,26 @@ (effects (font (size 1.27 1.27)) (justify left bottom)) (uuid eaa855c8-32a4-4450-9050-9d86f5fa408a) ) + (text "Invalid USB connection" (at 19.05 170.18 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 5b35d8bd-2642-4e63-9d91-a60f975db0c0) + ) + (text "Missing line inmpedance adjustment" (at 19.05 173.99 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 0c39b69a-9c5e-4ad6-adfc-8ea6575a3326) + ) + (text "Missing transient voltage protection" (at 19.05 194.31 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 64f3828c-2401-4779-9686-c7c124c8d79a) + ) (text "WATCHDOG" (at 34.925 19.05 0) (effects (font (size 2 2) (thickness 0.4) bold) (justify left bottom)) (uuid a8c311b3-ed81-4119-b589-93a5c63e6751) ) + (text "Intetionally empty?" (at 35.56 133.35 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 3d7011df-095e-4c4e-9a53-5ac80e79de8c) + ) (text "Reset" (at 45.085 71.12 0) (effects (font (size 2 2) (thickness 0.4) bold) (justify left bottom)) (uuid 480c3375-4523-48e7-98c1-d9b31b518a4c) @@ -2047,6 +2072,10 @@ (effects (font (size 1.27 1.27)) (justify left bottom)) (uuid f5dcdd11-ce97-4b1f-ba59-c27cf847f283) ) + (text "Inconsistent SPI Chip_select naming" (at 82.55 152.4 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid a06ccb96-1253-46a8-bcbb-23359c1cab19) + ) (text "High-Speed oscillator" (at 85.725 171.45 0) (effects (font (size 2 2) (thickness 0.4) bold) (justify left bottom)) (uuid 7cd06a7f-06fa-4cd5-a879-1226b343440f) @@ -2059,6 +2088,10 @@ (effects (font (size 2 2) (thickness 0.4) bold) (justify left bottom)) (uuid 7071d21f-a340-4b29-b9ad-54e06225002e) ) + (text "VDDUSB not connected\nto USB voltage" (at 133.35 74.93 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid da49d7a0-d07b-4258-a5d9-1c7f98ff11b7) + ) (text "Low-Speed oscillator" (at 136.525 171.45 0) (effects (font (size 2 2) (thickness 0.4) bold) (justify left bottom)) (uuid 4713ba73-7475-43e7-94f7-c9f882301c03) @@ -2067,6 +2100,14 @@ (effects (font (size 1.27 1.27)) (justify left bottom)) (uuid f7d9b2ec-c0df-4662-90c8-9909c84b451c) ) + (text "Missing power flag" (at 153.67 22.86 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 766d22bb-807b-492d-a247-75e552fc8513) + ) + (text "USB should be\ndifferential" (at 161.29 139.7 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 46e5f71d-34ce-43f8-ba05-1401f11d9e0d) + ) (text "Decoupling" (at 189.23 149.225 90) (effects (font (size 1.27 1.27)) (justify left bottom)) (uuid 4d08a862-84cc-419f-9ca6-1667b50a9fe4) @@ -2085,6 +2126,10 @@ (effects (font (size 1.27 1.27)) (justify left bottom)) (uuid b241b1f5-8a83-4767-948f-d4633a553b85) ) + (text "Insufficient decoupling capacitors" (at 227.33 40.64 0) + (effects (font (size 1.27 1.27)) (justify left bottom)) + (uuid 30ca5fa1-f582-4220-bbd1-2b26bb54cee9) + ) (text "Decoupled MCU capacitors" (at 228.6 24.13 0) (effects (font (size 1.5 1.5)) (justify left bottom)) (uuid 7b7658d3-0141-4ca6-bd5f-273daa58cfc3)